Refactor buoyancy and add moist anelastic option. #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR adds a header file with each of the buoyancy types included as inline host device functions. Additionally a moist option for anelastic is included. This code is taken from Heus et al 2010. Where we have the following:
It is noted that the
theta_vcomputation removes theL/(cp*Pi)*qcfactor so we have omitted it in the PR for computational efficiency. Additionally, the source term enters the w momentum equation asq/theta_0 * theta_v. This is not in a form where the background state has been subtracted off. Following the cited work of Wyngaard 2004 we have:Based upon the above, the background
theta_v_0obtained fromp0 & r0is utilized to define the deviation and reference value.